ci: consolidate format & generate workflows - #485
Merged
Conversation
uncenter
marked this pull request as ready for review
January 31, 2024 02:17
uncenter
changed the title
sgoudham
approved these changes
Jan 31, 2024
sgoudham
left a comment
sgoudham
left a comment
Contributor
There was a problem hiding this comment.
Looks fine, guess we won't really know until it's live.
sgoudham
requested changes
Jan 31, 2024
sgoudham
left a comment
sgoudham
left a comment
Contributor
There was a problem hiding this comment.
Actually, just caught something. We can remove the if conditions on the add and commit action and move it to the git push step? Since that's what we want to prevent when it's running on a fork.
Member
Author
|
Right. Shouldn't we move it to be an if statement for the whole job? Just don't run any of it? Why would we do that only on individual steps? |
Member
Author
|
Ah, turns out we don't have the |
sgoudham
approved these changes
Jan 31, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the race condition between the two workflows committing to the repository by combining them into one. Requires switching the commit workflow from
stefanzweifel/git-auto-commit-actiontoEndBug/add-and-commitbecause the former lacks a way to disable pushing the commit immediately.